etcdserver,embed: clean up/reorganize client/peer/corrupt handlers #8898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preliminary commit for initial hash checking. Dial timeout when other nodes have not been booted. Signed-off-by: Gyu-Ho Lee <[email protected]>
Signed-off-by: Gyu-Ho Lee <[email protected]>
Signed-off-by: Gyu-Ho Lee <[email protected]>
xiang90
reviewed
Nov 20, 2017
embed/etcd.go
Outdated
| @@ -66,13 +66,13 @@ const ( | |||
| type Etcd struct { | |||
| Peers []*peerListener | |||
| Clients []net.Listener | |||
| clientServers map[string]*serveCtx | |||
There was a problem hiding this comment.
Wanted to make it clear that it handles client requests.
There was a problem hiding this comment.
this is a map that contains the context of the server that handles the client requires.
the important part is that it is a map of context. so we cannot really get rid of the ctx part.
i would rather keep the previous name, and add comments to the field.
There was a problem hiding this comment.
Got it. Just reverted that name change.
Will merge after test passes. Thanks.
|
lgtm |
xiang90
reviewed
Nov 20, 2017
embed/etcd.go
Outdated
| @@ -66,13 +66,14 @@ const ( | |||
| type Etcd struct { | |||
| Peers []*peerListener | |||
| Clients []net.Listener | |||
| sctxs map[string]*serveCtx // client servers | |||
There was a problem hiding this comment.
// a map of contexts for the servers that serves client requests.
Priliminary commit to start client server later. Signed-off-by: Gyu-Ho Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #8554.
Preliminary work for #8313.
This doesn't change any server behavior.