Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e/docker-dns-srv: test with TLS #8654

Merged
merged 4 commits into from
Oct 5, 2017
Merged

e2e/docker-dns-srv: test with TLS #8654

merged 4 commits into from
Oct 5, 2017

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Oct 5, 2017

To test #8651.

@@ -14,6 +14,9 @@
],
"CN": "example.com",
"hosts": [
"*.etcd.local"
"*.etcd.local",
"etcd.local",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: "etcd.local", can be removed with #8651. But keeping it here for older versions.

@xiang90
Copy link
Contributor

xiang90 commented Oct 5, 2017

lgtm. but this probably can be merged into our e2e test (make e2e test run under container evn in the future?)

@gyuho
Copy link
Contributor Author

gyuho commented Oct 5, 2017

Sure, I will add those simple tests to semaphore.

@gyuho
Copy link
Contributor Author

gyuho commented Oct 5, 2017

Later we can run e2e tests against this cluster.
c.f. #8502

@gyuho gyuho merged commit c58ba62 into etcd-io:master Oct 5, 2017
@gyuho gyuho deleted the update branch October 5, 2017 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants