Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server/storage: change deprecated bolt error to new error package #17701

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

idnandre
Copy link
Contributor

@idnandre idnandre commented Apr 3, 2024

  • bbolt v.1.4.0-alpha has deprecated error in errors.go and introduce new error package
  • This PR will change from using deprecated error to new error package

@k8s-ci-robot
Copy link

Hi @idnandre. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@siyuanfoundation
Copy link
Contributor

/ok-to-test

@siyuanfoundation
Copy link
Contributor

/retest

@siyuanfoundation
Copy link
Contributor

/lgtm. Thanks for updating this!

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks @idnandre

Probably a question for @ahrtr - are we comfortable merging this while bbolt 1.4.0 is still alpha? We know etcd 3.6. aka main will depend on bbolt 1.4.0 so should be ok but just double checking in case we want to wait for non alpha release.

@ahrtr
Copy link
Member

ahrtr commented Apr 3, 2024

Probably a question for @ahrtr - are we comfortable merging this while bbolt 1.4.0 is still alpha? We know etcd 3.6. aka main will depend on bbolt 1.4.0 so should be ok but just double checking in case we want to wait for non alpha release.

it should be fine, as etcd main branch already depends on bbolt 1.4.0-alpha.0.

Once we finish etcd-io/bbolt#580, I will release bbolt 1.4.0-rc.0.

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Thank you!

@idnandre
Copy link
Contributor Author

idnandre commented Apr 4, 2024

thank you for reviewing my PR, guys 🎉

@ahrtr ahrtr merged commit 24f5f06 into etcd-io:main Apr 4, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants