-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server/storage: change deprecated bolt error to new error package #17701
Conversation
idnandre
commented
Apr 3, 2024
- bbolt v.1.4.0-alpha has deprecated error in errors.go and introduce new error package
- This PR will change from using deprecated error to new error package
Signed-off-by: idnandre <[email protected]>
Hi @idnandre. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/retest |
/lgtm. Thanks for updating this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should be fine, as etcd main branch already depends on bbolt 1.4.0-alpha.0. Once we finish etcd-io/bbolt#580, I will release bbolt 1.4.0-rc.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thank you!
thank you for reviewing my PR, guys 🎉 |