-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.5] backport e2e WaitLeader #17381
[3.5] backport e2e WaitLeader #17381
Conversation
Signed-off-by: Ivan Valdes <[email protected]>
Hi @ivanvc. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Ivan Valdes <[email protected]>
Signed-off-by: Ivan Valdes <[email protected]>
d71f923
to
8b24932
Compare
Overall looks good to me. @ivanvc Please mark this PR as Ready for review when you feel comfortable. thx |
I tested the |
/ok-to-test |
Not sure what exactly issue you are fixing in that commit. Please raise a separate issue or PR to discuss.
Yes, we need to backport to 3.4 as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in multiple issues and pull requests (#16822, #15247), this is the backport of
WaitLeader
to the release-3.5 branch.Etcdctl
from tests/e2e to tests/framework/e2e. This is required due to a circular dependency when requesting the status usingEtcdctl
from tests/framework/e2e.EtcdProcess
'sEtcdctl
, so getting a client from individual members is possible.EtcdProcessCluster
'sWaitLeader
, by adapting the code from the main branch. These required 1 and 2 to be implemented.Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.