Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies generated by the bot manually #16731

Merged
merged 3 commits into from
Oct 10, 2023

Conversation

…0718164431-9a2bf3000d16 to 0.5.0

Signed-off-by: Sharath Sivakumar <[email protected]>
…olang.org/grpc/otelgrpc from 0.44.0 to 0.45.0

Signed-off-by: Sharath Sivakumar <[email protected]>
@sharathsivakumar
Copy link
Contributor Author

@ahrtr and @jmhbnz Please review the changes and let me know if changes are needed. I had few inputs/comments

  • The net package required sys and crypto as dependencies. So I have made the changes in a single commit
  • While updating the prometheus_client package I can see the message that "go: module github.com/golang/protobuf is deprecated: Use the "google.golang.org/protobuf" module instead". We might have to upgrade this sometime. But since it is a critical package I have not made the upgrades in this PR. Do you think it would be a good idea to create a separate PR addressing the protobuf upgrade?

@ahrtr
Copy link
Member

ahrtr commented Oct 10, 2023

Please let's do not change protobuf for now, there is an issue tracking it. #14533

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @sharathsivakumar

@serathius serathius merged commit 4540db9 into etcd-io:main Oct 10, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants