Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize experimental corruption check #9190

Open
gyuho opened this issue Jan 22, 2018 · 5 comments
Open

Stabilize experimental corruption check #9190

gyuho opened this issue Jan 22, 2018 · 5 comments

Comments

@gyuho
Copy link
Contributor

gyuho commented Jan 22, 2018

We need to stabilize corruption check features with more documentation.

  • etcd --experimental-initial-corrupt-check
  • etcd --experimental-corrupt-check-time

Reference #9064

@jpbetz
Copy link
Contributor

jpbetz commented Aug 19, 2019

mTLS required for this to be promoted to be stable

@stale
Copy link

stale bot commented Apr 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 6, 2020
@stale stale bot closed this as completed May 28, 2020
@serathius serathius reopened this Mar 10, 2022
@stale stale bot removed the stale label Mar 10, 2022
@serathius
Copy link
Member

Motivation of reopen: #13775

@lavalamp
Copy link

Can we make checking a merkle root part of the graduation criteria? See discussion in: #13839

@serathius
Copy link
Member

serathius commented Jun 13, 2022

@lavalamp Depending on the difficulty it might make more sense to graduate corruption check earlier. As https://github.com/etcd-io/etcd/blob/main/Documentation/postmortems/v3.5-data-inconsistency.md#detection states corruption check is currently very limited and there are simpler improvements that we can implemented before Merkle Root.

My current plan would be for v3.6 to make the corruption check reliable by storing hash values in WAL. I would expect Merkle root to be no earlier than v3.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants