Update to Go v1.22 broke getting test coverage

[ivanvc]

Bug report criteria

• This bug report is not security related, security issues should be disclosed privately via [email protected].
• This is not a support request or question, support requests or questions should be raised in the etcd discussion forums.
• You have read the etcd bug reporting guidelines.
• Existing open issues along with etcd frequently asked questions have been checked and this is not a duplicate.

What happened?

After the Go 1.22 update, the coverage workflow has been failing. See https://github.com/etcd-io/etcd/actions/workflows/coverage.yaml.

After some investigation, it is possible to duplicate the issue locally. It seems like v1.22 had a significant coverage rewrite, which appears to be broken.

What did you expect to happen?

The coverage workflow should run as expected.

How can we reproduce it (as minimally and precisely as possible)?

Currently, the main branch is presenting the issue. Refer to https://github.com/etcd-io/etcd/actions/workflows/coverage.yaml to see the failed runs.

Anything else we need to know?

No response

Etcd version (please run commands below)

$ etcd --version
# paste output here

$ etcdctl version
# paste output here

Etcd configuration (command line flags or environment variables)

paste your configuration here

Etcd debug information (please run commands below, feel free to obfuscate the IP address or FQDN in the output)

$ etcdctl member list -w table
# paste output here

$ etcdctl --endpoints=<member list> endpoint status -w table
# paste output here

Relevant log output

No response

[ivanvc]

I opened golang/go#66211, as this issue hasn't been reported yet.

An immediate workaround is running the coverage with the environment variable GOEXPERIMENT=nocoverageredesign.

I see two possible solutions inject GOEXPERIMENT=nocoverageredesign:

1. in scripts/codecov_upload.sh (https://github.com/etcd-io/etcd/blob/main/scripts/codecov_upload.sh#L11)
2. in scripts/test.sh

The first option will fix the GitHub workflow. But running the coverage locally will still fail. Given that it should be a temporary workaround, I think the first option is acceptable.

[ahrtr]

Thanks @ivanvc for raising this issue, which I wanted to raise but did not get time to do it.

The first option will fix the GitHub workflow. But running the coverage locally will still fail. Given that it should be a temporary workaround, I think the first option is acceptable.

Agreed for now. We can fix it for now, but let's keep this issue open and see what's the feedback on golang/go#66211

[ivanvc]

/assign

[ivanvc]

Seems like it's likely going to be fixed in Go 1.23

Ref: golang/go#66137

[ivanvc]

Update: The fix was backported into 1.22, so the next release (1.22.2) should close this issue.

[ivanvc]

I just tested locally with the newly released 1.22.2, and the issue is gone. Once we update it, I'll open a PR to remove the workaround.