Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus on fixing flaky test cases and bugs #17322

Closed
ahrtr opened this issue Jan 25, 2024 · 4 comments
Closed

Focus on fixing flaky test cases and bugs #17322

ahrtr opened this issue Jan 25, 2024 · 4 comments
Labels
area/community priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. type/feature

Comments

@ahrtr
Copy link
Member

ahrtr commented Jan 25, 2024

What would you like to be added?

There are 43 open bugs (label: type/bug) and 11 flaky test issues (label: type/flake) at the moment of writing. We also see flaky workflows from time to time, usually the PR authors just ignore the failures as long as the failures have nothing to do with their PRs.

I'd suggest the community to focus on fixing flaky test cases, bugs and failed workflows (we may not create issue for each failed workflow) , and on-hold development on new features until we feel comfortable (e.g. flaky test issue + bugs < 10).

Why is this needed?

To improve stability and gain more confidence.

cc @Elbehery @jmhbnz @fuweid @serathius @spzala

@ahrtr ahrtr pinned this issue Jan 25, 2024
@ahrtr ahrtr added area/community priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jan 25, 2024
@Elbehery
Copy link
Member

thanks @ahrtr

I am actually assigned to #13919

it targets the e2e tests .. I tried going through the test framework to find my way, but i was lacking two main things

also maybe we can triage some for todays meeting @jmhbnz

@fuweid
Copy link
Member

fuweid commented Jan 25, 2024

SGTM. Will keep more eyes on this.

@serathius
Copy link
Member

Based on
https://github.com/etcd-io/etcd/actions/runs/7597605377/job/20692607792 we see 13% of flake. We should identify the source of flake.

@ahrtr ahrtr unpinned this issue May 2, 2024
@jmhbnz
Copy link
Member

jmhbnz commented Jun 6, 2024

Discussed during sig-etcd triage meeting. @ahrtr did you have any specific action items for the community to complete for this? The issue is generic so are there sub issues underneath?

@ahrtr ahrtr closed this as completed Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/community priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. type/feature
Development

No branches or pull requests

5 participants