From 7181c7532f80704d74a1b9e1658fa5cd34c4b4af Mon Sep 17 00:00:00 2001
From: Marek Siarkowicz <siarkowicz@google.com>
Date: Wed, 8 May 2024 10:37:43 +0200
Subject: [PATCH] Relax assumptions about all client request persisted in WAL
 to only require first and last request to be persisted

This assumption is not true during durability issues like #14370.
In reality we want to avoid situations where WAL is was truncated, for
that it's enough that we ensure that first and last operations are
present.

Found it when running `make test-robustness-issue14370` and instead of
getting `Model is not linearizable` I got that assumptions were broken.

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
---
 tests/robustness/validate/validate.go | 39 ++++++++++++++++++++-------
 1 file changed, 30 insertions(+), 9 deletions(-)

diff --git a/tests/robustness/validate/validate.go b/tests/robustness/validate/validate.go
index 5c49ee6851a..cd99a547d84 100644
--- a/tests/robustness/validate/validate.go
+++ b/tests/robustness/validate/validate.go
@@ -149,17 +149,38 @@ func validatePersistedRequestMatchClientRequests(reports []report.ClientReport,
 		}
 	}
 
-	for requestDump, op := range clientRequests {
-		request := op.Input.(model.EtcdRequest)
-		response := op.Output.(model.MaybeEtcdResponse)
-		if response.Error != "" || request.IsRead() {
-			continue
-		}
-		_, found := persistedRequestSet[requestDump]
-		if !found {
-			return fmt.Errorf("succesful client write %+v was not persisted, required to validate", requestDump)
+	var firstOp, lastOp porcupine.Operation
+	for _, r := range reports {
+		for _, op := range r.KeyValue {
+			request := op.Input.(model.EtcdRequest)
+			response := op.Output.(model.MaybeEtcdResponse)
+			if response.Error != "" || request.IsRead() {
+				continue
+			}
+			if firstOp.Call == 0 || op.Call < firstOp.Call {
+				firstOp = op
+			}
+			if lastOp.Call == 0 || op.Call > lastOp.Call {
+				lastOp = op
+			}
 		}
 	}
+	firstOpData, err := json.Marshal(firstOp.Input.(model.EtcdRequest))
+	if err != nil {
+		return err
+	}
+	_, found := persistedRequestSet[string(firstOpData)]
+	if !found {
+		return fmt.Errorf("first succesful client write %s was not persisted, required to validate", firstOpData)
+	}
+	lastOpData, err := json.Marshal(lastOp.Input.(model.EtcdRequest))
+	if err != nil {
+		return err
+	}
+	_, found = persistedRequestSet[string(lastOpData)]
+	if !found {
+		return fmt.Errorf("last succesful client write %s was not persisted, required to validate", lastOpData)
+	}
 	return nil
 }