Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the commands' usage description #729

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Apr 17, 2024

Old output:

$ ./bbolt surgery meta update -h
Update fields in meta pages

Usage:
  bbolt surgery meta update <bbolt-file> [options] [flags]

Flags:
      --fields strings     comma separated list of fields (supported fields: pageSize, root, freelist and pgid) to be updated, and each item is a colon-separated key-value pair
  -h, --help               help for update
      --meta-page uint32   the meta page ID to operate on, valid values are 0 and 1
      --output string      path to the filePath db file

New output:

$ ./bbolt surgery meta update -h
Update fields in meta pages

Usage:
  bbolt surgery meta update <bbolt-file> [flags]

Flags:
      --fields strings     comma separated list of fields (supported fields: pageSize, root, freelist and pgid) to be updated, and each item is a colon-separated key-value pair
  -h, --help               help for update
      --meta-page uint32   the meta page ID to operate on, valid values are 0 and 1
      --output string      path to the filePath db file

@ahrtr
Copy link
Member Author

ahrtr commented Apr 17, 2024

cc @fuweid @tjungblu @ivanvc

@ahrtr ahrtr changed the title Simplify the command's description Simplify the commands' usage description Apr 17, 2024
@Elbehery
Copy link
Member

LGTM

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cmd/bbolt/command_root.go Show resolved Hide resolved
@ahrtr
Copy link
Member Author

ahrtr commented Apr 18, 2024

cc @fuweid @tjungblu

@ivanvc ivanvc mentioned this pull request Apr 18, 2024
@ahrtr ahrtr force-pushed the update_surgery_cmd_20240417 branch from b174443 to f7de41e Compare April 18, 2024 11:19
@ahrtr
Copy link
Member Author

ahrtr commented Apr 20, 2024

I expect we can depend on @Elbehery @ivanvc @tjungblu @fuweid to review bbolt CMD changes.

and @fuweid and @tjungblu to review all bbolt changes.

@Elbehery
Copy link
Member

Certainly .. i actually can start working in cobra migration for all cmds

@ahrtr
Copy link
Member Author

ahrtr commented Apr 20, 2024

Certainly .. i actually can start working in cobra migration for all cmds

Thanks, but please read #472 (comment)

@ivanvc
Copy link
Member

ivanvc commented Apr 21, 2024

Certainly .. i actually can start working in cobra migration for all cmds

Thanks, but please read #472 (comment)

I suggest to divide and conquer once we are able to migrate the commands

Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahrtr ahrtr merged commit 5ae7bc6 into etcd-io:main Apr 21, 2024
16 checks passed
@ahrtr ahrtr deleted the update_surgery_cmd_20240417 branch June 26, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants