migrate bbolt info command to cobra style

[charles-chenzz]

#472
migrate bbolt info to cobra style

[jmhbnz]

Hey @charles-chenzz - Thanks for your work on this. Please resolve test failures detected by make fmt.

[charles-chenzz]

@jmhbnz sorry for the ping, but I've run make fmt and fix the import issue, the CI logs still failed

please ignore, I'll take a look on it

[jmhbnz]

Thanks for addressing the fmt errors @charles-chenzz. I've reviewed the changes, please see two suggestions below.

[jmhbnz]

Suggest validating args cobra style, if I don't supply the DB path currently and just run bbolt info all I get is a panic and it's unclear from a user perspective what was done wrong.

Example arg validation:

bbolt/cmd/bbolt/command_surgery.go

Lines 57 to 65 in cd4a757

	Args: func(cmd *cobra.Command, args []string) error {
	if len(args) == 0 {
	return errors.New("db file path not provided")
	}
	if len(args) > 1 {
	return errors.New("too many arguments")
	}
	return nil
	},

[charles-chenzz]

I think this can use

Args: cobra.ExactArgs(1)

but I've use the example that you list

[jmhbnz]

LGTM - Thanks @charles-chenzz

[jmhbnz]

Discussed during sig-etcd triage meeting. This would be a breaking change, we will hold merging this until we release 1.4.0.

[charles-chenzz]

Discussed during sig-etcd triage meeting. This would be a breaking change, we will hold merging this until we release 1.4.0.

it's ok. Thanks for clarifying this! @jmhbnz