-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: refactor worker/operation and support Delete operation #469
Conversation
cc @tjungblu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment above.
Signed-off-by: Benjamin Wang <[email protected]>
Resolved. PTAL |
lgtm (non-binding). Shall we maybe also add some basic linearizability tests for bbolt? |
Looks great! thanks. |
The test case is testing a local library instead of a distributed system, so I don't think it needs test linearizability. FYI. #455 (comment) |
FYI Linearizability is property of concurrent objects, not necessarily distributed systems. https://jepsen.io/consistency/models/linearizable. You can apply it to any concurrent primitive, including semaphores, locks, concurrent maps and transaction key-value stores like bbolt. |
Exactly, a distributed system is not that much different than the concurrency on your multi-core CPU.
Somewhat agreed, it's not a strict requirement for bbolt to be linearizable to make etcd linearizable. But does it hurt to add it? Worst case we waste some dev time, best case we find some issue. |
Delete
operation