Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow editing Capture autoDiscover properties #676

Closed
psFried opened this issue Jul 5, 2023 · 0 comments
Closed

Allow editing Capture autoDiscover properties #676

psFried opened this issue Jul 5, 2023 · 0 comments
Assignees
Labels
create Creating an entity edit Editing an entity enhancement New feature or request

Comments

@psFried
Copy link
Member

psFried commented Jul 5, 2023

estuary/flow#1078 adds the autoDiscover properties to Capture specs. These allow users to opt in to periodic background discover operations that get automatically published. The UI should allow users to set these properties during capture creation, and also edit them for existing captures.

  • AutoDiscover can be enabled or disabled
    • Enabled is represented as any non-null value of autoDiscover, such as autoDiscover: {} or autoDiscover: {addNewBindings: false}
    • Disabled is represented as either null or undefined. Though we technically need to support both of these for compatibility, we should prefer an explicit null
  • addNewBindings determines whether to add newly discovered bindings to the capture. If false, then it will only ever update existing bindings. If true, then it will both add new bindings and update existing ones. There's no option for adding new bindings without also updating the existing ones.
  • evolveIncompatibleCollections determines the behavior of the publications handler when a newly discovered collection is rejected due to being incompatible. If true, then a failed publication due to incompatible collection changes will automatically trigger an evolutions job and a subsequent publication of the updated draft. If false, then the publication will just fail and that'll be the end of it. (Eventually, we'll need alerting for the latter case, but we'll discuss that later.)
@kiahna-tucker kiahna-tucker added enhancement New feature or request edit Editing an entity create Creating an entity labels Jul 6, 2023
@kiahna-tucker kiahna-tucker self-assigned this Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create Creating an entity edit Editing an entity enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants