Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESP32 improvements #1880

Merged
merged 2 commits into from
Jul 14, 2020
Merged

ESP32 improvements #1880

merged 2 commits into from
Jul 14, 2020

Conversation

MaBecker
Copy link
Contributor

  • add FLASH_BAUD
  • fix erase_flash
  • switch jsWarn() to jsDevInfo()
  • keep jsWarn()/ jsError() for not implemented functions
  • switch jsError() to jsExceptionHere() if helpfull

@MaBecker
esp32_improvements
bbc3726 
- add FLASH_BAUD
- fix erase_flash
- switch jsWarn()  to jsDevInfo()
- keep jsWarn()/ jsError() for not implemented functions
- switch jsError() to jsExceptionHere() if helpfull
This was referenced Jul 13, 2020
Closed
Open
@gfwilliams
Copy link
Member

Thanks - looks great!

However with bluetooth.c, don't we actually want to keep the warnings, or some kind of print that appears for normal release users? It feels quite important to tell them that a function isn't implemented - potentially it should even be an exception.

@MaBecker
esp32_improvement
a38b805 
* keep jsWarn() for not implemented functions
* add Exceptions for issues
@MaBecker
Copy link
Contributor Author

Thanks, yes keep jsWarn() for BLE and just add jsExceptionHere() where useful.

@gfwilliams
Copy link
Member

Thanks!

@gfwilliams gfwilliams merged commit 3cc623b into espruino:master Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaBecker @gfwilliams