Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pre-installed python packages and rely on requirements.txt #51

Closed
wants to merge 1 commit into from

Conversation

XzzX
Copy link
Member

@XzzX XzzX commented May 7, 2021

Remove preinstalled python dependencies and rely on pip install -r requirements.txt.

closes #49

@XzzX
Copy link
Member Author

XzzX commented May 7, 2021

@junghans Any ideas for the mpi specific packages? How to generalize the installation process?

@XzzX XzzX requested a review from junghans May 7, 2021 08:00
@junghans
Copy link
Member

junghans commented May 7, 2021

Wouldn't we first add pip install -r requirements.txt to the other CI?

@XzzX
Copy link
Member Author

XzzX commented May 7, 2021

Wouldn't we first add pip install -r requirements.txt to the other CI?

espressopp/espressopp#377

@junghans
Copy link
Member

junghans commented May 7, 2021

After thinking about it, I would suggest to keep MPI related package from the distros to avoid incompatibilities.

@XzzX
Copy link
Member Author

XzzX commented May 8, 2021

I agree, pip will recognize them and not reinstall them.

@XzzX XzzX closed this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop "pip3 install pyh5md"
2 participants