-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wokwi): Add support for specifying diagram path #296
feat(wokwi): Add support for specifying diagram path #296
Conversation
9a2cd3d
to
7e6eb46
Compare
Hi @P-R-O-C-H-Y! The code changes LGTM. However, if I've downloaded the old wokwi-cli release and run the test, the new cli args
Could you add more code to handle this use case? I can come up with a few solutions here.
Overall I'll pick solution 2, and welcome any other ideas! |
7e6eb46
to
66536c2
Compare
This PR adds a support of specifying diagram file for pytest-embedded-wokwi. To specify diagram.json add --wokwi-diagram to the pytest command Co-Authored-By: Fu Hanxi <[email protected]>
7894374
to
1383c2e
Compare
@hfudev All required changes are done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for your PR!
This PR adds a support of specifying diagram file for pytest-embedded-wokwi.
To specify diagram.json add --wokwi-diagram to the pytest command