Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strange behaviour when you disable ASCII serial support (IDFGH-13866) #77

Open
3 tasks done
AtomBalmBaby opened this issue Oct 11, 2024 · 1 comment
Open
3 tasks done
Assignees

Comments

@AtomBalmBaby
Copy link

Checklist

  • Checked the issue tracker for similar issues to ensure this is not a duplicate
  • Read the documentation to confirm the issue is not addressed there and your configuration is set correctly
  • Tested with the latest version to ensure the issue hasn't been fixed

How often does this bug occurs?

always

Expected behavior

with modbus ASCII support disabled in the Configuration editor, I expect a simple modbus implemention ( modbus rtu slave example project) to compile without error

Actual behavior (suspected bug)

if i disable ascii mode (which I don't want or need for my application) I cannot compile cleanly.

enabling ascii support causes the issue to go away, and I can get things to compile. seems like an issue with the library configuration cmake stuff to me.

Error logs or terminal output

/mnt/NAS1/DEVEL/Crypto/firefly/managed_components/espressif__esp-modbus/modbus/mb_objects/mb_slave.c: In function 'mbs_ascii_create':
/mnt/NAS1/DEVEL/Crypto/firefly/managed_components/espressif__esp-modbus/modbus/mb_objects/mb_slave.c:148:11: error: implicit declaration of function 'mbs_ascii_transp_create'; did you mean 'mbs_tcp_transp_create'? [-Werror=implicit-function-declaration]
  148 |     ret = mbs_ascii_transp_create(ser_opts, (void **)&transp_obj);
      |           ^~~~~~~~~~~~~~~~~~~~~~~
      |           mbs_tcp_transp_create
/mnt/NAS1/DEVEL/Crypto/firefly/managed_components/espressif__esp-modbus/modbus/mb_objects/mb_slave.c:164:9: error: implicit declaration of function 'mbs_ascii_transp_delete'; did you mean 'mbs_tcp_transp_delete'? [-Werror=implicit-function-declaration]
  164 |         mbs_ascii_transp_delete(transp_obj);
      |         ^~~~~~~~~~~~~~~~~~~~~~~
      |         mbs_tcp_transp_delete

Steps to reproduce the behavior

configure modbus module parameters and then try to build

Project release version

2.0.0 beta

System architecture

Intel/AMD 64-bit (modern PC, older Mac)

Operating system

Linux

Operating system version

Fedora 40

Shell

Bash

Additional context

No response

@github-actions github-actions bot changed the title strange behaviour when you disable ASCII serial support strange behaviour when you disable ASCII serial support (IDFGH-13866) Oct 11, 2024
@alisitsyn
Copy link
Collaborator

alisitsyn commented Oct 24, 2024

@AtomBalmBaby ,

Thank you for reporting. This will be fixed. This will be added to plan and I will let you know once merged.

@alisitsyn alisitsyn self-assigned this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants