Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeRTOS/coreMQTT Support (IDFGH-4261) #6112

Closed
AshUK opened this issue Nov 12, 2020 · 8 comments
Closed

FreeRTOS/coreMQTT Support (IDFGH-4261) #6112

AshUK opened this issue Nov 12, 2020 · 8 comments
Labels
Type: Feature Request Feature request for IDF

Comments

@AshUK
Copy link
Contributor

AshUK commented Nov 12, 2020

Currently, the MQTT component makes use of the esp-mqtt library supported and maintained by espressif. Although this is a feature-rich library it does lack the many of qualities of CoreMQTT such as the extensive unit test code coverage and code quality.

Now that FreeRTOS/coreMQTT has reached released will there be planned support or an option to switch out the current component?

FreeRTOS/coreMQTT#98

@AshUK AshUK added the Type: Feature Request Feature request for IDF label Nov 12, 2020
@github-actions github-actions bot changed the title FreeRTOS/coreMQTT Support FreeRTOS/coreMQTT Support (IDFGH-4261) Nov 12, 2020
@Alvin1Zhang
Copy link
Collaborator

Thanks for raising the feature request.

@lhespress
Copy link
Collaborator

@AshUK
Please replace esp-idf/components/mqtt and esp-idf/examples/protocols/mqtt/ssl to the attached files.

FreeRTOS:coreMQTT.zip

@AshUK
Copy link
Contributor Author

AshUK commented Dec 2, 2020

@lhespress Thanks very much for this port, I really was not expecting a response so soon.

I have tested and it appears to be working as expected.

Free heap during a active MQTTS connection:
FreeRTOS=198068
ESP=192672

A saving of 5396 bytes seems promising.

@KaeLL
Copy link
Contributor

KaeLL commented Dec 2, 2020

@AshUK will you submit a PR?

@AshUK
Copy link
Contributor Author

AshUK commented Dec 3, 2020

@KaeLL It wouldn't be my place to submit the PR as @lhespress has done all work.

@lhespress Do you know if there there is a plan to add this to the IDF ?

@lhespress
Copy link
Collaborator

lhespress commented Dec 4, 2020

@AshUK

I have submit a MR to the IDF for reviewing. I'll update the progress to you ASAP.

@lhespress
Copy link
Collaborator

@AshUK Hi, freertos coremqtt has been pushed on github, please check https://github.com/espressif/esp-freertos-coremqtt

@Alvin1Zhang
Copy link
Collaborator

Thanks for reporting, feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Request Feature request for IDF
Projects
None yet
Development

No branches or pull requests

4 participants