-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong condition in HTTP version check routine (esp_http_server component) (IDFGH-13878) #14723
Closed
3 tasks done
Labels
Resolution: NA
Issue resolution is unavailable
Status: Done
Issue is done internally
Type: Bug
bugs in IDF
Comments
github-actions
bot
changed the title
Wrong condition in HTTP version check routine (esp_http_server component)
Wrong condition in HTTP version check routine (esp_http_server component) (IDFGH-13878)
Oct 14, 2024
Hello @valkuc Thank you for bringing this change to our attention. We've raised a merge request, which will be reflected in the main repository soon. |
espressif-bot
added
Status: Reviewing
Issue is being reviewed
Status: Done
Issue is done internally
Resolution: NA
Issue resolution is unavailable
and removed
Status: Opened
Issue is new
Status: Reviewing
Issue is being reviewed
labels
Oct 21, 2024
@nileshkale123 The release branches also need fix. |
Sure. It's already in progress. Thanks |
espressif-bot
pushed a commit
that referenced
this issue
Nov 12, 2024
espressif-bot
pushed a commit
that referenced
this issue
Nov 19, 2024
espressif-bot
pushed a commit
that referenced
this issue
Nov 26, 2024
espressif-bot
pushed a commit
that referenced
this issue
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Resolution: NA
Issue resolution is unavailable
Status: Done
Issue is done internally
Type: Bug
bugs in IDF
Answers checklist.
IDF version.
v5.3.1
Espressif SoC revision.
ESP32-C3
Operating System used.
Windows
How did you build your project?
Command line with idf.py
If you are using Windows, please specify command line type.
CMD
Development Kit.
Custom Board
Power Supply used.
USB
What is the expected behavior?
ESP HTTP server component should refuse to execute HTTP 1.0 request.
What is the actual behavior?
ESP HTTP server component executing HTTP 1.0 request.
Steps to reproduce.
Use curl to issue HTTP 1.0 request to ESP board:
curl -0 -v http://esp-board.local
Debug Logs.
No response
More Information.
There is an error in condition here
esp-idf/components/esp_http_server/src/httpd_parse.c
Line 89 in 6e5a178
Logical
AND
should be replaced withOR
:The text was updated successfully, but these errors were encountered: