Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BLE appearance values according to bluetooth-SIG (IDFGH-12628) #13626

Closed
PocketPi opened this issue Apr 16, 2024 · 5 comments
Closed

Update BLE appearance values according to bluetooth-SIG (IDFGH-12628) #13626

PocketPi opened this issue Apr 16, 2024 · 5 comments
Assignees
Labels
Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally Type: Feature Request Feature request for IDF

Comments

@PocketPi
Copy link

PocketPi commented Apr 16, 2024

Is your feature request related to a problem?

I was trying to set the appearance value to 0x0841 (Audio Sink - Standalone Speaker) but got and error with the api: esp_ble_gap_config_local_icon

esp_err_t icon_err = esp_ble_gap_config_local_icon(0x0841);
if (icon_err) {
    ESP_LOGE(BLE_TAG, "set icon failed, error code = %x", icon_err);
}

I dug into the code and saw that only a subset of appearance values are allowed.

Describe the solution you'd like.

Either keep the list of allowed values up to date. Or make an interface for using all values

Describe alternatives you've considered.

No response

Additional context.

No response

@PocketPi PocketPi added the Type: Feature Request Feature request for IDF label Apr 16, 2024
@espressif-bot espressif-bot added the Status: Opened Issue is new label Apr 16, 2024
@github-actions github-actions bot changed the title Update BLE appearance values according to bluetooth-SIG Update BLE appearance values according to bluetooth-SIG (IDFGH-12628) Apr 16, 2024
@esp-zhp
Copy link
Collaborator

esp-zhp commented Apr 17, 2024

image
image
image

@esp-zhp
Copy link
Collaborator

esp-zhp commented Apr 17, 2024

@PocketPi
You're right, we will update it. For your normal usage, you can first add 0x0841.thanks for reporting the issue.

@esp-zhp
Copy link
Collaborator

esp-zhp commented Apr 17, 2024

Fix commit will coming soon:
master 0a4636a
v5.2 c079772
v5.1 151976a
v5.0 e45d91c
v4.4 5420548

@PocketPi
Copy link
Author

Super thanks,

@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable and removed Status: Opened Issue is new labels Apr 18, 2024
@Indastri
Copy link
Collaborator

Indastri commented Jul 1, 2024

Closing as the issue was solved.

Cheers!

@Indastri Indastri closed this as completed Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally Type: Feature Request Feature request for IDF
Projects
None yet
Development

No branches or pull requests

4 participants