Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esp_http_client does not handle URL with space (IDFGH-9170) #10566

Closed
3 tasks done
AxelLin opened this issue Jan 18, 2023 · 3 comments
Closed
3 tasks done

esp_http_client does not handle URL with space (IDFGH-9170) #10566

AxelLin opened this issue Jan 18, 2023 · 3 comments
Assignees
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally Type: Bug bugs in IDF

Comments

@AxelLin
Copy link
Contributor

AxelLin commented Jan 18, 2023

Answers checklist.

  • I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
  • I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
  • I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.

v4.3.4-332-g56ee43ec5e

Operating System used.

Linux

How did you build your project?

Command line with idf.py

If you are using Windows, please specify command line type.

None

Development Kit.

ESP32-WROOM-32E

Power Supply used.

USB

What is the expected behavior?

esp_http_client should either provide API to do urlencode or handle it internally.

What is the actual behavior?

If the URL has space, it shows error:
e.g.

E (5419) HTTP_CLIENT: Error parse url http://192.168.0.104/test space/test
E (5426) HTTP_CLIENT: Failed to set URL

Steps to reproduce.

You can test using esp_http_client_example, just need to modify the URL setting to include space.

Debug Logs.

No response

More Information.

No response

@AxelLin AxelLin added the Type: Bug bugs in IDF label Jan 18, 2023
@espressif-bot espressif-bot added the Status: Opened Issue is new label Jan 18, 2023
@github-actions github-actions bot changed the title esp_http_client does not handle URL with space esp_http_client does not handle URL with space (IDFGH-9170) Jan 18, 2023
@kriegste
Copy link

Spaces are no valid characters in URLs. They have to be encoded using %20

@AxelLin
Copy link
Contributor Author

AxelLin commented Jan 18, 2023

Spaces are no valid characters in URLs. They have to be encoded using %20

I know that.
maybe esp_http_client can provide API to encode it. (Otherwise people have to open-coded the same API)

@espressif-bot espressif-bot added Status: In Progress Work is in progress Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: Opened Issue is new Status: In Progress Work is in progress Resolution: NA Issue resolution is unavailable labels Jan 20, 2023
@laukik-hase
Copy link
Collaborator

Closed with 167618d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally Type: Bug bugs in IDF
Projects
None yet
Development

No branches or pull requests

4 participants