Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display color format / bits per pixel do not have public defines (BSP-283) #145

Closed
TT-Qt opened this issue Mar 13, 2023 · 3 comments
Closed

Comments

@TT-Qt
Copy link

TT-Qt commented Mar 13, 2023

Display color format / bits per pixel is not available from display.h or from esp-bsp.h ( via board specific header ).

In the BSP implementation these values are hardcoded.

Example from Korvo-2 BSP:

.color_space = ESP_LCD_COLOR_SPACE_BGR,
.bits_per_pixel = 16,

@TT-Qt TT-Qt changed the title Display color format / bits per pixel does not have public defines Display color format / bits per pixel do not have public defines Mar 13, 2023
@github-actions github-actions bot changed the title Display color format / bits per pixel do not have public defines Display color format / bits per pixel do not have public defines (BSP-283) Mar 13, 2023
@tore-espressif
Copy link
Collaborator

@TTauriainenQt yes, these values are constant and specific to the display that is shipped with korvo-2 board. Do you need to change these values?

@TT-Qt
Copy link
Author

TT-Qt commented Mar 13, 2023

We need these values for the drawing engine as we have to know the framebuffer format in which we are drawing into. Now we have to use hardcoded values in our code and it would be nice to get them directly from the BSP header.

@TT-Qt
Copy link
Author

TT-Qt commented Mar 13, 2023

Actually instead of ESP_LCD_COLOR_SPACE_BGR we would need to know the endianess. In case of Korvo-2 (and ESP-BOX) the framebuffer format needs to be big endian as the display interface uses such format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants