-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(pre-commit): Fix PR checks and cache #9531
Conversation
👋 Hello lucasssvaz, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
936146c
to
585ee9c
Compare
Memory usage test (comparing PR agains master branch)The table below shows the summary of memory usage change (min - max) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
The memory usage test has a glitch. There is no code change and the size checker shows some (small) changes. |
Already on it @Jason2866, but unfortunately the sizes are from arduino cli compilation. So it's a glitch there. But I can do a small workaround to not show (ignore) those fake small changes. But Thanks for pointing that out. |
Description of Change
Makes the pre-commit status check more elegant and properly work when the workflows need approval.
Also fix the caching by running the pre-commit workflow in the master branch on pushes (without automatic changes).
Tests scenarios
Tested in my fork