Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Get sizes from push workflow, updated build scripts #9524

Merged

Conversation

P-R-O-C-H-Y
Copy link
Member

Description of Change

This PR adds a 2nd run of compilation to the push.yml (ESP32 Arduino CI) workflow, which runs on the base branch and only if the workflow is triggered by PR. All compilation results are uploaded as artifacts and used by publishsizes.yml

Needs #9523 to be merged first.

  • removed Event file artifact upload from the external libs workflow.

Tests scenarios

Tested on my fork.

Related links

Copy link
Contributor

github-actions bot commented Apr 17, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Add 2nd compilation run on base branch":
    • summary looks empty
    • type/action looks empty
  • the commit message "Add compilation log to the build scripts":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fix PR number in publish sizes":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fix sketch_utils script":
    • summary looks empty
    • type/action looks empty
  • the commit message "Remove event-file from External libs wf":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update Push workflow":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update external libs results with pr num file":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update on-push.sh":
    • summary looks empty
    • type/action looks empty
  • the commit message "Upload pr number in lib.yml":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

⚠️ Please consider squashing your 11 commits (simplifying branch history).

👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 332399e

@me-no-dev me-no-dev marked this pull request as ready for review April 17, 2024 10:51
@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Apr 18, 2024
@me-no-dev me-no-dev merged commit 0219c21 into espressif:master Apr 18, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: CI & Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants