-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: USB HID Keyboard raw report #9473
Conversation
👋 Hello SuGlider, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
@me-no-dev - a quick fix. Please add it to release/v2.x branch too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of Change
Fixes key modifier bitmap when using
USBHIDKeyboard::pressRaw(uint8_t k)
andUSBHIDKeyboard::releaseRaw(uint8_t k)
.The modifiers are marked in a bitmap in the HID Report Descriptor.
Tests scenarios
ESP32-S2
Related links
Fix #9377