Add missing include for SemaphoreHandle_t to LEDC header file #9134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Add missing include references to
esp32-hal-ledc.h
for typeSemaphoreHandle_t
This header is used by the M5Unified library, via M5GFX, in the Light_PWM.cpp file and in that context does not have the required FreeRTOS semaphore type, so the build/compile fails. Files should generally include the references they use and not rely on other files having included necessary headers prior to them (in case they are loaded in a different order).
This is a minor change.
Tests scenarios
Tested on M5Stack Core2 (ESP32). Note that this is a compilation error, so can be reproduced without board (although after fixing I did test the sample ran). Sample code is in the bug report.
Related links
Fixes #9133
By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes
Checklist
This entire section above can be deleted if all items are checked.