-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "WiFiSTA - allow using DHCP again after disconnecting static IP" #8873
Revert "WiFiSTA - allow using DHCP again after disconnecting static IP" #8873
Conversation
espressif#8848)" This reverts commit a9a72d1.
I can see setting |
👋 Hello JAndrassy, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
This PR is ready to be merged as an Revert. |
I want to revert my recent PR #8848
It turned out that all libraries I tested preserved the static IP settings over
disconnect()
(except my WiFiEspAT). I learned that the right way to return to DHCP isconfig(INADDR_NONE, INADDR_NONE, INADDR_NONE)
. And this really worked in all WiFi libraries.So the user of the library can
config
the static IP and thendisconnect
and laterbegin
again with the same static IP.