[REDO] Update espota.py #8797
Merged
[REDO] Update espota.py #8797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes documented in comment section of code.
|
@SuGlider please try this on Windows this example should do |
|
Tested on MacOS. Worked well. |
lucasssvaz
approved these changes
Oct 24, 2023
|
@SuGlider could you please test on Windows? |
Test done. All fine! |
SuGlider
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a redo of #8239
Replaced the deprecated optparse module with argparse.
Adjusted the code style to conform to PEP 8 guidelines.
Used with statement for file handling to ensure proper resource cleanup.
Incorporated exception handling to catch and handle potential errors.
Made variable names more descriptive for better readability.
Introduced constants for better code maintainability.