Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Wire.setClock() causing assert #8777

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Fix Wire.setClock() causing assert #8777

merged 2 commits into from
Oct 16, 2023

Conversation

me-no-dev
Copy link
Member

When Wire.setClock() is called after Wire.begin() an assert is triggered due to changes in clock calculations

fixes: #8772

When Wire.setClock() is called after Wire.begin() an assert is triggered due to changes in clock calculations
@me-no-dev me-no-dev marked this pull request as ready for review October 16, 2023 13:56
@me-no-dev me-no-dev merged commit 93a118c into master Oct 16, 2023
36 checks passed
@me-no-dev me-no-dev deleted the bugfix/i2c_set_clock branch October 16, 2023 14:50
@rottaran
Copy link

Hello me-no-dev, great fix!
I got the same issue with ESP32S3 in the idf-release/v5.1 branch. I copied your changes and it fixed the problem too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

I2C - Wire Library crashing when setting clock frequency > 142857 Hz
2 participants