HTTPClient - Fix case sensitiveness for header keys #8630
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
According to the RFC, header keys for HTTP/1.x should be treated as case-insensitive.
String HTTPClient::header(const char* name)
andbool HTTPClient::hasHeader(const char* name)
will, incorrectly, perform case-sensitive comparisons.This PR makes HTTPClient comparisons for header keys case-insensitive.
Tests scenarios
Tested using the following sketch on ESP32:
Output
Related links
Closes #8524