Support relative paths in UNIX search PATH #8622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuGlider
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
It sounds good. Using absolute path for bash increases security.
Anyway, it doesn't affect Windows.
We may think about something similar for cmd.exe
I'll test it here as well using Win ENV VAR ComSpec
UPDATE: it seems that Arduino CLI doesn't accept ENV VARs.
Other platforms use some scripts or tools, like busybox to overcome it.
cmd.exe will be found in WIN PATH. No action for it at this time.
P-R-O-C-H-Y
approved these changes
Oct 3, 2023
P-R-O-C-H-Y
added
Status: Pending Merge
|
@me-no-dev this will be part of 2.0.15 release, right? |
|
if released :) i'll port it over to 3.0.0 too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8610