-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add USB MIDI support to libraries/USB #8166
Conversation
Thanks! And I was already suspicious on how silent the arduino-cli output was, I just discovered the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EleotleCram PTAL on my comments.
Also please add skip files to examples for esp32c6 and esp32h2.
Thanks! Good job :)
Hello @EleotleCram, thanks for you PR. Unfortunately it seems that CLA form did not show up for your first contribution. Can you please check https://cla-assistant.io/ if you have the CLA signed for this repository. Thanks a lot |
@VojtechBartoska AFAIK I already signed the CLA for this repository; when I log in to cla-assistant and I view my signed CLAs it lists this repo. |
@P-R-O-C-H-Y , I just noticed things were moving again for this PR. I've checked your comments, but it seems the changes have already been made by now, do I need to take further action? |
Hi @EleotleCram, I took over the PR and fixed all the stuff we noticed in the reviews. |
Description of Change
This PR adds support for USB MIDI to libraries/USB. It wraps the underlying tiny-usb API in an Arduino-like/User-friendly API, similar to the already existing USBHID* classes.
Tests scenarios
All the examples have been tested using an ESP32-S2 Mini. Please see the related links section for video-proof that it works.
Related links