Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(esptool): Bump esptool version to 4.9.dev1 on 3.0.x #10572

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

lucasssvaz
Copy link
Collaborator

Description of Change

Bump esptool version to v4.9.dev1 on branch release/v3.0.x.

It includes adding back binaries for macOS x86_64 and fixes for USB resetting on S2 and S3.

Tests scenarios

Tested locally.

Related links

#6762

@lucasssvaz lucasssvaz added Type: CI & Testing Area: Tools & Build System Issue is related to tools and/or the build system labels Nov 5, 2024
@lucasssvaz lucasssvaz requested a review from me-no-dev November 5, 2024 15:21
@lucasssvaz lucasssvaz self-assigned this Nov 5, 2024
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Warnings
⚠️
	The **target branch** for this Pull Request **must be the default branch** of the project (`master`).

	If you would like to add this feature to a different branch, please state this in the PR description and we will consider it.

👋 Hello lucasssvaz, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 66a4973

@lucasssvaz lucasssvaz force-pushed the fix/esptool_version_3.0 branch from d877207 to 6059491 Compare November 5, 2024 15:27
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Test Results

 56 files   56 suites   4m 18s ⏱️
 21 tests  21 ✅ 0 💤 0 ❌
134 runs  134 ✅ 0 💤 0 ❌

Results for commit 66a4973.

♻️ This comment has been updated with latest results.

@me-no-dev me-no-dev added the Status: Pending Merge Pull Request is ready to be merged label Nov 5, 2024
@me-no-dev me-no-dev merged commit a2952eb into release/v3.0.x Nov 5, 2024
71 of 73 checks passed
@me-no-dev me-no-dev deleted the fix/esptool_version_3.0 branch November 5, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Tools & Build System Issue is related to tools and/or the build system Status: Pending Merge Pull Request is ready to be merged Type: CI & Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants