Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-blocking ADC functions gone #5205

Closed
Triangulix opened this issue May 22, 2021 · 16 comments
Closed

Non-blocking ADC functions gone #5205

Triangulix opened this issue May 22, 2021 · 16 comments
Assignees
@P-R-O-C-H-Y
Labels
Area: Peripherals API Relates to peripheral's APIs. Status: Solved
Milestone
3.0.0

Comments

@Triangulix
Copy link

Hi

I just updated from 1.0.4 to 1.0.6 and realized that the non-blocking ADC functions adcStart, adcBusy and adcEnd have been removed.

How should we now use the ADC without blocking the program flow while the ADC is working?
@Gamelauncher Gamelauncher mentioned this issue May 25, 2021
Closed
@stale
Copy link

stale bot commented Jul 23, 2021

[STALE_SET] This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: Stale Issue is stale stage (outdated/stuck) label Jul 23, 2021
@Triangulix
Copy link
Author

I am now stuck on version 1.0.4, the last version with non-broken non-blocking ADC. Great.

@stale
Copy link

stale bot commented Jul 23, 2021

[STALE_CLR] This issue has been removed from the stale queue. Please ensure activity to keep it openin the future.

@stale stale bot removed the Status: Stale Issue is stale stage (outdated/stuck) label Jul 23, 2021
@stale
Copy link

stale bot commented Sep 22, 2021

[STALE_SET] This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: Stale Issue is stale stage (outdated/stuck) label Sep 22, 2021
@Triangulix
Copy link
Author

Any news on this topic?

@stale
Copy link

stale bot commented Sep 22, 2021

[STALE_CLR] This issue has been removed from the stale queue. Please ensure activity to keep it openin the future.

@stale stale bot removed the Status: Stale Issue is stale stage (outdated/stuck) label Sep 22, 2021
@VojtechBartoska
Copy link
Contributor

Hello @Triangulix , are you able to test your issue on development version 2.0.3-RC1 to check if this is still valid? ADC was refactored lately.

Take a look on Docs where is explained how to choose development release version in Arduino IDE.

@VojtechBartoska VojtechBartoska added Area: Peripherals API Relates to peripheral's APIs. Resolution: Awaiting response Waiting for response of author labels Apr 7, 2022
@Triangulix
Copy link
Author

@VojtechBartoska Since no-one replied for so long I changed the design and the ADCs are not used anymore.

@VojtechBartoska
Copy link
Contributor

Sorry for that, we missed it. Thanks for understanding, closing as expired.

@VojtechBartoska VojtechBartoska added Resolution: Expired More info wasn't provided and removed Resolution: Awaiting response Waiting for response of author labels Apr 7, 2022
@sumitmamoria
Copy link

@VojtechBartoska I can confirm that the issue is there in the latest version as well.

@VojtechBartoska
Copy link
Contributor

@sumitmamoria Can you please provide a sketch for reproducing the issue? Thanks!

@VojtechBartoska VojtechBartoska added this to the 2.0.6 milestone Nov 21, 2022
@VojtechBartoska VojtechBartoska added Resolution: Awaiting response Waiting for response of author and removed Resolution: Expired More info wasn't provided labels Nov 30, 2022
@VojtechBartoska VojtechBartoska removed this from the 2.0.6 milestone Nov 30, 2022
@positron96
Copy link
Contributor

The functions are still gone and they would really be useful to me.

@VojtechBartoska the issue is with missing functionality and functions, I don't think a reproducing sketch is possible. You can follow the history here: #220

@VojtechBartoska VojtechBartoska added Status: Needs investigation We need to do some research before taking next steps on this issue and removed Resolution: Awaiting response Waiting for response of author labels Feb 15, 2023
@VojtechBartoska
Copy link
Contributor

@P-R-O-C-H-Y Can you please triage this request? Thanks!

@P-R-O-C-H-Y P-R-O-C-H-Y added this to the 3.0.0 milestone Jul 21, 2023
@P-R-O-C-H-Y P-R-O-C-H-Y moved this from Todo to Under investigation in Arduino ESP32 Core Project Roadmap Jul 21, 2023
@VojtechBartoska VojtechBartoska moved this from Under investigation to In Progress in Arduino ESP32 Core Project Roadmap Jul 26, 2023
@VojtechBartoska VojtechBartoska added Status: In Progress Issue is in progress and removed Status: Needs investigation We need to do some research before taking next steps on this issue labels Jul 26, 2023
@lbernstone
Copy link
Contributor

ADC was refactored to allow the functions to work on all variants (which have different registers for these peripherals). If you still want this functionality on an esp32, you can add the functions directly to your code from 1.0.4

@P-R-O-C-H-Y P-R-O-C-H-Y mentioned this issue Aug 4, 2023
Closed
@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Review needed Issue or PR is awaiting review and removed Status: In Progress Issue is in progress labels Aug 16, 2023
@P-R-O-C-H-Y P-R-O-C-H-Y moved this from In Progress to In Review in Arduino ESP32 Core Project Roadmap Aug 16, 2023
@P-R-O-C-H-Y
Copy link
Member

If there is anyone who is already trying the new development version 3.0 using IDF-5.1 which is under esp-idf-v5.1-libs branch, you can give a try to the new ADC Continuous mode in PR #8490. Any feedback would be welcome. Thanks

@P-R-O-C-H-Y P-R-O-C-H-Y mentioned this issue Oct 5, 2023
Merged
@VojtechBartoska
Copy link
Contributor

Closing this as solved by above mentioned PR.

@VojtechBartoska VojtechBartoska added Status: Solved and removed Status: Review needed Issue or PR is awaiting review labels Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@P-R-O-C-H-Y P-R-O-C-H-Y

Labels
Area: Peripherals API Relates to peripheral's APIs. Status: Solved
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
3.0.0
Development

No branches or pull requests
6 participants
@positron96 @lbernstone @Triangulix @sumitmamoria @VojtechBartoska @P-R-O-C-H-Y