Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

partitions: default.csv vs. default.bin #3414

Closed
dl9rdz opened this issue Oct 27, 2019 · 2 comments
Closed

partitions: default.csv vs. default.bin #3414

dl9rdz opened this issue Oct 27, 2019 · 2 comments
Labels
Status: Stale Issue is stale stage (outdated/stuck)

Comments

@dl9rdz
Copy link

dl9rdz commented Oct 27, 2019

tools/partitions/default.csv has been updated by #2678 to move spiffs partition to offset 0x290000 instead of 0x291000, but tools/partitions/default.bin has not been updated.

> grep spiffs esp32/1.0.4/tools/partitions/default.csv 
spiffs,   data, spiffs,  0x290000,0x170000,
> python gen_esp32part.py esp32/1.0.4/tools/partitions/default.bin | grep spiffs
spiffs,data,spiffs,0x291000,1468K,

It is rather confusing and error prone to have two files with matching names (default.csv and default.bin), but inconsistent content (took me some time to figure out why my SPIFFS that I flashed at 0x290000 together with the default.bin partition table was not working). I guess this is not intentional. Would it be possible to update default.bin in the next release such that it matches default.csv?

@stale
Copy link

stale bot commented Dec 26, 2019

[STALE_SET] This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: Stale Issue is stale stage (outdated/stuck) label Dec 26, 2019
@stale
Copy link

stale bot commented Jan 9, 2020

[STALE_DEL] This stale issue has been automatically closed. Thank you for your contributions.

@stale stale bot closed this as completed Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Stale Issue is stale stage (outdated/stuck)
Projects
None yet
Development

No branches or pull requests

1 participant