fix missing the first bit in HC589 shift in (#2448)

espressif · Feb 14, 2019 · c0345ea · c0345ea
1 parent 71ec3c3
commit c0345ea
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/cores/esp32/wiring_shift.c b/cores/esp32/wiring_shift.c
@@ -25,11 +25,12 @@ uint8_t shiftIn(uint8_t dataPin, uint8_t clockPin, uint8_t bitOrder) {
     uint8_t i;
 
     for(i = 0; i < 8; ++i) {
-        digitalWrite(clockPin, HIGH);
+        //digitalWrite(clockPin, HIGH);
         if(bitOrder == LSBFIRST)
             value |= digitalRead(dataPin) << i;
         else
             value |= digitalRead(dataPin) << (7 - i);
+        digitalWrite(clockPin, HIGH);
         digitalWrite(clockPin, LOW);
     }
     return value;