-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WString: unify numeric conversion and fix assignments #8526
Merged
+321
−103
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1b56cb2
WString: unify numeric conversion and fix assignments
mcspr a192705
cannot assign to uninitialized obj, try to placement-new replace the …
mcspr 7e67800
mention the abundance of init()
mcspr 16dff0e
implement host test
mcspr 0ca7702
oops
mcspr 4206518
trying to reduce the instances of where we specify the default base /…
mcspr 44c8a24
use pointer from the func, don't default to the &buf[0]
mcspr d963949
hint about the length of the buffer
mcspr 9ce12d1
Merge branch 'master' into arduino-string-can-assign-stuff
mcspr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
trying to reduce the instances of where we specify the default base /…
… decimalPlaces branch via if (base == 10) { sprintf(...) } else { ... } instead of separate funcs reuse the constructor for numeric types where it's possible
commit 4206518be226a95d34b2038a0dd78e28a648fe5e
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is mostly for verbosity. Due to the amount of magic ctors we have... we can't really have
std::initializer_list<char>
ctor as well, since everything would be converted into ite.g.
So only purpose of the below is to allow to omit
String{...}
in front of the arguments list. Where we suppose to haveexplicit
forString(int, base)
overloadCould be reverted though.