New menu option to minimize BSSL ROM with only RSA #6006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
earlephilhower
changed the title
Adds a menu option and define to limit BearSSL to older RSA connection options. This saves ~45K program memory and can speed up connections since EC, while more secure, is significantly slower on the chip. The supported ciphers are identical to the ones that axTLS supported. Fixes esp8266#6005
earlephilhower
force-pushed
the
lowmemssl
branch
from
9332262 to
01df6f9
Compare
d-a-v
approved these changes
Apr 24, 2019
devyte
approved these changes
Apr 25, 2019
|
@d-a-v, do you have a better solution? Think this is something that should only be settable from platform_local.txt? |
|
Not a better solution. Indeed another (worse) solution is to use platform.local.txt (like this example #6003 (comment)). It is worse because it is not easily selectable, while not confusing users with tons of options. So no, to be honest, I prefer the tool menu option (even for #6003). I wish this menu were more configurable so we can put less obvious choices below a single "uncommon" option. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a menu option and define to limit BearSSL to older RSA connection
options. This saves ~45K program memory and can speed up connections
since EC, while more secure, is significantly slower on the chip.
The supported ciphers are identical to the ones that axTLS supported.
Fixes #6005