Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error out in some form when no table could be found parsing an elf for defmt #523

Closed
Vollbrecht opened this issue Nov 26, 2023 · 1 comment · Fixed by #524
Closed

error out in some form when no table could be found parsing an elf for defmt #523

Vollbrecht opened this issue Nov 26, 2023 · 1 comment · Fixed by #524

Comments

@Vollbrecht
Copy link

current behavior just silently does nothing if no table found when user runs espflash like espflash monitor --elf=test --log-format=defmt

offending part https://github.com/esp-rs/espflash/blob/main/espflash/src/cli/monitor/parser/esp_defmt.rs#L88

@bugadani
Copy link
Contributor

defmt also doesn't make sense if there is no elf file specified (or inferred) anyway. So we just shouldn't proceed if the result of load_table is None, and we should probably replace the Option with a Result and meaningful errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants