bt-hci dependency pulled when enabling defmt feature

[DBLouis]

Bug description

When defmt feature of esp-wifi crate is enabled, bt-hci is added to Cargo.lock even though ble feature is not enabled.

To Reproduce

Add esp-wifi with ble feature disabled and defmt enabled.

Expected behavior

bt-hci dependency should not be added if ble feature is disabled.

Environment

• Target device: ESP32
• Crate name and version: esp-wifi 0.12.0

[bugadani]

This is a cargo quirk - Cargo.lock may contain optional dependencies even if they are not activated.

[DBLouis]

Ok, but this is not without consequences, I can see different behavior when bt-hci is present in Cargo.lock, even if I am not using bluetooth and ble feature is not enabled.

[bugadani]

What difference in behavior can you see?

[DBLouis]

First of all, the executable is different, and second, the ESP output this line at start:
[WARN] - esp_wifi_internal_tx 12290
Which seems to make the WiFi unstable.

[bugadani]

You are enabling logging, why would you expect the executable to remain unchanged?

[WARN] - esp_wifi_internal_tx 12290

The error code is 0x3002, which is ESP_ERR_WIFI_NOT_STARTED. Not sure why this would be related to bt-hci, but you're seeing the log line because you're enabling defmt.

[DBLouis]

Makes sense