Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the single byte read/write inherent functions #2808

Closed
Tracked by #2494
bjoernQ opened this issue Dec 13, 2024 · 3 comments · Fixed by #2915
Closed
Tracked by #2494

Remove the single byte read/write inherent functions #2808

bjoernQ opened this issue Dec 13, 2024 · 3 comments · Fixed by #2915
Assignees
@JurajSadel
Labels
1.0-blocker peripheral:spi SPI peripheral
Milestone
0.23.0

Comments

@bjoernQ
Copy link
Contributor

bjoernQ commented Dec 13, 2024

No description provided.

@bjoernQ bjoernQ mentioned this issue Dec 13, 2024
Open
41 tasks
@bjoernQ bjoernQ added the peripheral:spi SPI peripheral label Dec 13, 2024
@tom-borcin tom-borcin added the investigation Not needed for 1.0, but don't know if we can support without breaking the driver. label Dec 16, 2024
@MabezDev MabezDev added this to the 1.0.0-beta.0 milestone Jan 6, 2025
@MabezDev
Copy link
Member

MabezDev commented Jan 8, 2025

Let's remove them. They are a relic of old eh versions, and can be emulated with driver.write_bytes(&[data])?.

@MabezDev MabezDev removed the investigation Not needed for 1.0, but don't know if we can support without breaking the driver. label Jan 8, 2025
@MabezDev
Copy link
Member

MabezDev commented Jan 8, 2025

Note to implementer: could you also check other (stable) drivers than spi to see if we need to do the same.

@MabezDev MabezDev changed the title Do we want the single byte read/write inherent functions? or are they optimized for the job and are much more efficient? is it a common use case? Remove the single byte read/write inherent functions Jan 8, 2025
@JurajSadel JurajSadel self-assigned this Jan 8, 2025
@SergioGasquez
Copy link
Member

Uart also has read_byte and write_byte

@SergioGasquez SergioGasquez mentioned this issue Jan 9, 2025
Merged
6 tasks
@JurajSadel JurajSadel mentioned this issue Jan 9, 2025
Merged
@MabezDev MabezDev mentioned this issue Jan 9, 2025
Closed
@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JurajSadel JurajSadel

Labels
1.0-blocker peripheral:spi SPI peripheral
Projects
esp-rs
Archived in project
Milestone
0.23.0
Development

Successfully merging a pull request may close this issue.

Remove the single byte read/write inherent functions JurajSadel/esp-hal
5 participants
@bjoernQ @MabezDev @SergioGasquez @JurajSadel @tom-borcin