Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2度目のhook通知を17時30分にセットした #44

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

2度目のhook通知を17時30分にセットした #44

wants to merge 3 commits into from

Conversation

uesaka-seiya
Copy link
Collaborator

@uesaka-seiya uesaka-seiya commented Nov 16, 2020 •
edited
Loading

close #43

試しに↓のように書いてみたところ30秒毎に動くことは確認できました。

    @Scheduled(cron = "0 * * * * 1-5", zone = "Asia/Tokyo")
    @Scheduled(cron = "30 * * * * 1-5", zone = "Asia/Tokyo")
    public void postToHook() {
        // 処理
    }

もっとエレガントなやり方とかあれば教えてください。

@uesaka-seiya uesaka-seiya self-assigned this Nov 16, 2020
RyuyaMaeda
RyuyaMaeda previously approved these changes Nov 19, 2020
View reviewed changes
Copy link
Collaborator

@RyuyaMaeda RyuyaMaeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uesaka-seiya
レビューしました、良いと思います

@RyuyaMaeda RyuyaMaeda dismissed their stale review November 19, 2020 23:16

一点確認したいことがあったので一旦取り消します:bow:

@RyuyaMaeda
Copy link
Collaborator

二度目のhook通知で次の掃除当番に通知が行く気がします。
微妙ですが、10時に実行されるgetCleaner()は別で考えた方がいいかもしれないです。
こちらで他の掃除忘れ防止策についても考えてみたいと思います。

@uesaka-seiya
Copy link
Collaborator Author

そうでした（その日の夕方に掃除当番交代してもらっちゃ困る） 🙈
getCleaner()実行のタイミングを考えてみます

@uesaka-seiya uesaka-seiya marked this pull request as draft November 30, 2020 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyuyaMaeda RyuyaMaeda RyuyaMaeda left review comments

Assignees

@uesaka-seiya uesaka-seiya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

夕方にもHOOK通知をする
2 participants
@uesaka-seiya @RyuyaMaeda