-
-
Notifications
You must be signed in to change notification settings - Fork 75
Breaking: typescript-estree to 13.5.2 and typescript to 3.2.1 #592
Conversation
I haven't had a chance to discuss with other team members how best to do the releases for these changes, so here's a straw proposal: I would like to do releases for the latest typescript-estree corresponding with each Typescript version. So for example, this PR has the latest release for Typescript 3.2.1. I don't have a strong desire to release for every version of Typescript, so if we (for example) don't have a PR for a typescript-estree release for 3.2.0, we don't need to create one. In this way, there'll be at least one typescript-eslint-parser release for most Typescript versions. @armano2 Could you please comment here with which PRs correspond with each Typescript version? Don't close the other PRs yet, in case we end up going a different direction. @kaicataldo @mysticatea Thoughts on the proposal above? |
starting from all my prs except #583 are from versions 3.2.1. latest version of
most of major changes to ast seems to be done (unless i missed something) from ast perspective typescript 3.2.x introduced only 2 changes, BooleanKeyword and BooleanLiteral. nodes you can see difference in produced AST without |
@platinumazure Please see my comment here: #584 (comment) |
Closing in favour of #596 |
This PR contains changes from #576, #584, #589, #590, #591 and deprecates changes from #581
v13.5.1 - v12.0.0 changes:
JamesHenry/typescript-estree@v12.0.0...v13.5.1
changes with master: JamesHenry/typescript-estree@v5.3.0...v13.5.1
PRs with changes to ast:
TSNamespaceFunctionDeclaration
is no longer present in ASTTSEmptyBodyDeclareFunction
andTSEmptyBodyFunctionDeclaration
are now unified toTSDeclareFunction
FunctionDeclaration
will beTSDeclareFunction
if there is no body present.fixes: #414, #588, #384, #593