Skip to content
This repository has been archived by the owner on Jan 19, 2019. It is now read-only.

Breaking: typescript-estree to 13.5.2 and typescript to 3.2.1 #592

Closed
wants to merge 14 commits into from

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Jan 6, 2019

This PR contains changes from #576, #584, #589, #590, #591 and deprecates changes from #581

v13.5.1 - v12.0.0 changes:

JamesHenry/typescript-estree@v12.0.0...v13.5.1

changes with master: JamesHenry/typescript-estree@v5.3.0...v13.5.1

PRs with changes to ast:


  • node TSNamespaceFunctionDeclaration is no longer present in AST
  • nodes TSEmptyBodyDeclareFunction and TSEmptyBodyFunctionDeclaration are now unified to TSDeclareFunction
  • node FunctionDeclaration will be TSDeclareFunction if there is no body present.

fixes: #414, #588, #384, #593

@platinumazure
Copy link
Member

I haven't had a chance to discuss with other team members how best to do the releases for these changes, so here's a straw proposal: I would like to do releases for the latest typescript-estree corresponding with each Typescript version. So for example, this PR has the latest release for Typescript 3.2.1. I don't have a strong desire to release for every version of Typescript, so if we (for example) don't have a PR for a typescript-estree release for 3.2.0, we don't need to create one. In this way, there'll be at least one typescript-eslint-parser release for most Typescript versions.

@armano2 Could you please comment here with which PRs correspond with each Typescript version? Don't close the other PRs yet, in case we end up going a different direction.

@kaicataldo @mysticatea Thoughts on the proposal above?

@armano2
Copy link
Contributor Author

armano2 commented Jan 6, 2019

starting from typescript-estree v6 there is support for typescript 3.2.1

all my prs except #583 are from versions 3.2.1.

latest version of typescript-estree with before ts3.2.1 is currently used one 5.3.0


typescript-estree releases one version per change, if change is breaking it increases major version.
there was a lot of small fixes with ranges, missing fields, etc in AST, but there was also a lot of changes to names of properties, names of nodes and structure of AST.

most of major changes to ast seems to be done (unless i missed something)


from ast perspective typescript 3.2.x introduced only 2 changes, BooleanKeyword and BooleanLiteral.


nodes TS***Type are present in currently used version of typescript-estree, and properties for them didn't change (in most cases), but they had fallback support in typescript-estree (copy nodes from ts to estree as any unknown node)


you can see difference in produced AST without errorOnUnknownASTType here estree-13.5.2...estree-5.3

@armano2 armano2 changed the title Breaking: typescript-estree to 13.5.1 and typescript to 3.2.1 Breaking: typescript-estree to 13.5.2 and typescript to 3.2.1 Jan 8, 2019
@JamesHenry
Copy link
Member

@platinumazure Please see my comment here: #584 (comment)

@JamesHenry
Copy link
Member

Closing in favour of #596

@JamesHenry JamesHenry closed this Jan 12, 2019
@armano2 armano2 deleted the estree-13.5.1 branch January 13, 2019 01:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

type declarations should have distinct AST from vars
4 participants