Skip to content
This repository has been archived by the owner on Jan 19, 2019. It is now read-only.

Fix: issue with global augmentation when tokens are not present #574

Merged
merged 1 commit into from
Dec 3, 2018

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Nov 30, 2018

This PR solves issue with: #570

i had to upgrade typescript-estree to latest version with solution for JamesHenry/typescript-estree#27

additionally lodash is no longer used in project

@armano2 armano2 changed the title fix: issue with global augmentation when tokens are not present Fix: issue with global augmentation when tokens are not present Nov 30, 2018
@armano2 armano2 force-pushed the global-augmentation branch from 6185765 to 7b93280 Compare November 30, 2018 20:56
Copy link
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@mysticatea mysticatea added bug and removed triage labels Dec 1, 2018
@mysticatea
Copy link
Member

I'm not familiar with this parser, in fact. When I see #573, the update of typescript-estree looks a breaking change, but I'm not sure.

@armano2
Copy link
Contributor Author

armano2 commented Dec 2, 2018

@mysticatea you should look on this one #567

@platinumazure
Copy link
Member

I'm going to rerun the Travis build just to make sure it still passes on latest master-- if it does, then I'll merge this in. Thanks for your patience!

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@platinumazure platinumazure merged commit 47abd82 into eslint:master Dec 3, 2018
@armano2 armano2 deleted the global-augmentation branch December 3, 2018 17:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants