Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: Dependencies (fixes #40) #41

Merged
merged 1 commit into from
Jan 16, 2016
Merged

Upgrade: Dependencies (fixes #40) #41

merged 1 commit into from
Jan 16, 2016

Conversation

btmills
Copy link
Member

@btmills btmills commented Jan 16, 2016

This will pull in the changes to eslint-config-eslint from eslint/eslint#4910, which requires eslint@2. Updated object-assign as well to clean up npm outdated output.

@btmills
Copy link
Member Author

btmills commented Jan 16, 2016

Looks like npm@2 doesn't like the peer dependency on [email protected]. Barring some creative solution, I'm going to hold off until ESLint 2 is released.

@btmills
Copy link
Member Author

btmills commented Jan 16, 2016

Turns out the solution was as simple as dropping the peer dependency. eslint-plugin-react doesn't specify a peer dependency and specifies the 2.0 beta in devDependencies, which is exactly what this does.

btmills added a commit that referenced this pull request Jan 16, 2016
Upgrade: Dependencies (fixes #40)
@btmills btmills merged commit 7dc4aca into master Jan 16, 2016
@btmills btmills deleted the deps branch January 16, 2016 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant