Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: add yarn.lock and package-lock.json into .gitignore just like eslint/eslint #184

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Chore: add yarn.lock and package-lock.json into .gitignore just like eslint/eslint #184

merged 1 commit into from
Mar 30, 2021

Conversation

JounQin
Copy link
Contributor

@JounQin JounQin commented Mar 30, 2021

@eslint-github-bot
Copy link

Hi @JounQin!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The length of the commit message must be less than or equal to 72

Read more about contributing to ESLint here

@eslint-github-bot
Copy link

Hi @JounQin!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The length of the commit message must be less than or equal to 72

Read more about contributing to ESLint here

Copy link
Member

@btmills btmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this exact change has already been made in eslint/eslint and eslint/espree, I'll use that precedent as approval for this repository as well.

@btmills btmills merged commit a09a645 into eslint:main Mar 30, 2021
@btmills
Copy link
Member

btmills commented Mar 30, 2021

Thanks @JounQin! Hopefully there's less friction as you're working on this repository from now on 🙂

@JounQin JounQin deleted the chore/gitignore branch March 30, 2021 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants