Fix: Ignore words in info string after syntax (fixes #166) #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was working correctly in v1 but stopped working when v2 switched to the new processor API. The generated filename was `0.js more words are ignored`. The test case for this was insufficiently strict: it asserted that the code block was extracted, which was sufficient with hard-coded extensions in v1, but it didn't assert the generated name was `0.js` now that we're taking the extension from the info string. Per CommonMark 0.29 [1]: > The line with the opening code fence may optionally contain some text > following the code fence; this is trimmed of leading and trailing > whitespace and called the info string. I've strengthened the tests for generated filename extensions and added a new test to ensure that leading whitespace is trimmed correctly. [1]: https://spec.commonmark.org/0.29/#info-string
simonbrunel
reviewed
Dec 16, 2020
Markdown info strings permit trimming both leading and trailing whitespace, so this shouldn't cause issues. `.trim()` is much nicer than a regex `.replace()`.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was working correctly in v1 but stopped working when v2 switched to the new processor API. The generated filename was
0.js more words are ignored. The test case for this was insufficiently strict: it asserted that the code block was extracted, which was sufficient with hard-coded extensions in v1, but it didn't assert the generated name was0.jsnow that we're taking the extension from the info string.Per CommonMark 0.29:
I've strengthened the tests for generated filename extensions and added a new test to ensure that leading whitespace is trimmed correctly.