-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: pluralize 'line' to 'lines' in max-lines-per-function description #14115
Docs: pluralize 'line' to 'lines' in max-lines-per-function description #14115
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @trevinhofmann, thanks for the PR!
The change looks good to me. Just to double-check, have you signed the CLA? (I believe you already signed before, I'm not sure why the status on the check is pending).
Note to the merger: the commit message should start with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CLA check is green now.
LGTM, thanks for contributing!
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
I fixed one word in the description of the
max-lines-per-function
rule by pluralizing it.Is there anything you'd like reviewers to focus on?
Please read the rule description to ensure grammar is now correct.