Fix: overrides pattern for virtual filenames in recommended config (#169

) * Fix: overrides pattern for virtual filenames in recommended config * Chore: Test settings configured by recommended config Co-authored-by: Brandon Mills <[email protected]>
eslint · Jan 31, 2021 · f6a3fad · f6a3fad
1 parent 390d508
commit f6a3fad
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 3 deletions.
diff --git a/lib/index.js b/lib/index.js
@@ -14,7 +14,10 @@ module.exports = {
             overrides: [
                 {
                     files: ["*.md"],
-                    processor: "markdown/markdown",
+                    processor: "markdown/markdown"
+                },
+                {
+                    files: ["**/*.md/**"],
                     parserOptions: {
                         ecmaFeatures: {
 

diff --git a/tests/fixtures/recommended.json b/tests/fixtures/recommended.json
@@ -1,6 +1,6 @@
 {
     "root": true,
-    "extends": "plugin:markdown/recommended",
+    "extends": ["eslint:recommended", "plugin:markdown/recommended"],
     "rules": {
         "no-console": "error"
     }

diff --git a/tests/lib/plugin.js b/tests/lib/plugin.js
@@ -20,6 +20,7 @@ const plugin = require("../..");
 function initCLI(fixtureConfigName, isAutofixEnabled) {
     const fix = isAutofixEnabled || false;
     const cli = new CLIEngine({
+        cwd: path.resolve(__dirname, "../fixtures/"),
         fix,
         ignore: false,
         useEslintrc: false,
@@ -35,7 +36,8 @@ describe("recommended config", () => {
     let cli;
     const shortText = [
         "```js",
-        "console.log(42);",
+        "var unusedVar = console.log(undef);",
+        "'unused expression';",
         "```"
     ].join("\n");
 
@@ -72,6 +74,23 @@ describe("recommended config", () => {
         assert.include(config.plugins, "markdown");
     });
 
+    it("applies convenience configuration", () => {
+        const config = cli.getConfigForFile("subdir/test.md/0.js");
+
+        assert.deepStrictEqual(config.parserOptions, {
+            ecmaFeatures: {
+                impliedStrict: true
+            }
+        });
+        assert.deepStrictEqual(config.rules["eol-last"], ["off"]);
+        assert.deepStrictEqual(config.rules["no-undef"], ["off"]);
+        assert.deepStrictEqual(config.rules["no-unused-expressions"], ["off"]);
+        assert.deepStrictEqual(config.rules["no-unused-vars"], ["off"]);
+        assert.deepStrictEqual(config.rules["padded-blocks"], ["off"]);
+        assert.deepStrictEqual(config.rules.strict, ["off"]);
+        assert.deepStrictEqual(config.rules["unicode-bom"], ["off"]);
+    });
+
     it("overrides configure processor to parse .md file code blocks", () => {
         const report = cli.executeOnText(shortText, "test.md");