Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(no-unsupported-features): Remove use of static as a variable #190

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

scagood
Copy link

@scagood scagood commented Feb 26, 2024

Thank you @alex-kinokon for spotting this!

@scagood scagood requested a review from aladdin-add February 26, 2024 18:22
Copy link

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we may want to enable the rule strict for this.

@aladdin-add aladdin-add merged commit e31d868 into master Feb 27, 2024
17 checks passed
@aladdin-add aladdin-add deleted the fix-no-unsupported-features-static branch February 27, 2024 01:53
@scagood
Copy link
Author

scagood commented Feb 27, 2024

LGTM, we may want to enable the rule strict for this.

I am in favour of that 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants